Update to ACK runtime v0.28.0, code-generator v0.28.0#168
Merged
ack-prow[bot] merged 1 commit intomainfrom Dec 21, 2023
Merged
Conversation
|
It looks like this is what's needed in order to support Pod Identity (see aws-controllers-k8s/community#1953 and aws-controllers-k8s/runtime#130). Currently when deployed with a pod identity, containers will crash with below: |
a-hilaly
force-pushed
the
ack-bot/rt-v0.28.0-codegen-v0.28.0
branch
from
4711aa5 to
343b7a3
Compare
a-hilaly
force-pushed
the
ack-bot/rt-v0.28.0-codegen-v0.28.0
branch
from
343b7a3 to
7da16c0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
@FabianPonce merging now :) |
nnbu
pushed a commit
to nnbu/ack-ec2-controller
that referenced
this pull request
Sep 18, 2024
…llers-k8s#168) ### Update to ACK runtime `v0.28.0`, code-generator `v0.28.0` ---------- * ACK code-generator `v0.28.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.28.0) * ACK runtime `v0.28.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.28.0) ---------- NOTE: This PR increments the release version of service controller from `v1.1.1` to `v1.1.2` Once this PR is merged, release `v1.1.2` will be automatically created for `ec2-controller` **Please close this PR, if you do not want the new patch release for `ec2-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. ==== building ec2-controller ==== Copying common custom resource definitions into ec2 Building Kubernetes API objects for ec2 Generating deepcopy code for ec2 Generating custom resource definitions for ec2 Building service controller for ec2 Generating RBAC manifests for ec2 Running gofmt against generated code for ec2 Updating additional GitHub repository maintenance files ==== building ec2-controller release artifacts ==== Building release artifacts for ec2-v1.1.2 Generating common custom resource definitions Generating custom resource definitions for ec2 Generating RBAC manifests for ec2 ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
nnbu
pushed a commit
to nnbu/ack-ec2-controller
that referenced
this pull request
Sep 18, 2024
Merged PRs since last release: - aws-controllers-k8s#167 - aws-controllers-k8s#168 - aws-controllers-k8s#172 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to ACK runtime
v0.28.0, code-generatorv0.28.0v0.28.0release notesv0.28.0release notesNOTE:
This PR increments the release version of service controller from
v1.1.1tov1.1.2Once this PR is merged, release
v1.1.2will be automatically created forec2-controllerPlease close this PR, if you do not want the new patch release for
ec2-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.